Jefffrey commented on code in PR #19189:
URL: https://github.com/apache/datafusion/pull/19189#discussion_r2616354789
##########
datafusion/functions/src/string/concat.rs:
##########
@@ -79,7 +81,31 @@ impl ScalarUDFImpl for ConcatFunc {
fn as_any(&self) -> &dyn Any {
self
}
+ fn return_field_from_args(
Review Comment:
We're still modifying the DF version? Is this intended?
##########
datafusion/spark/src/function/string/concat.rs:
##########
@@ -83,6 +81,26 @@ impl ScalarUDFImpl for SparkConcat {
// Accept any string types, including zero arguments
Ok(arg_types.to_vec())
}
+ fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> {
+ Ok(DataType::Utf8)
+ }
Review Comment:
We should leave this as an error, see other PRs for reference:
https://github.com/apache/datafusion/pull/19268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
