Jefffrey commented on code in PR #19189:
URL: https://github.com/apache/datafusion/pull/19189#discussion_r2617818216
##########
datafusion/functions/src/string/concat.rs:
##########
@@ -79,7 +81,31 @@ impl ScalarUDFImpl for ConcatFunc {
fn as_any(&self) -> &dyn Any {
self
}
+ fn return_field_from_args(
Review Comment:
> This PR only modifies the Spark implementation under datafusion/spark; the
DataFusion SQL concat is unchanged.
I would double check your diff here; this is very much not the case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
