sebbegg opened a new pull request, #1351:
URL: https://github.com/apache/datafusion-ballista/pull/1351
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #1349
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
See #1349. Having a proxy on the scheduler makes it easier to e.g. expose
this in docker-compose or kubernetes.
Making this a draft first, let me know what you think.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
This adds a "flight proxy" service to the scheduler that's optionally
startet, when `advertise_flight_sql_endpoint` is set.
This implements only `do_get` and simply proxies the requests to the actual
executor.
I reasoned that having this as a separate service (instead of another method
in the scheduler grpc) makes this more flexible since the code on the client
side remains almost unchanged - except for the logic to pick scheduler or
executor host as the endpoint.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
Kind of - using `advertise_flight_sql_endpoint` now actually has an effect.
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
