sebbegg commented on code in PR #1351:
URL:
https://github.com/apache/datafusion-ballista/pull/1351#discussion_r2635953109
##########
ballista/core/src/execution_plans/distributed_query.rs:
##########
@@ -360,9 +363,22 @@ async fn execute_query(
let duration = Duration::from_millis(duration);
info!("Job {job_id} finished executing in {duration:?} ");
+ let FlightEndpointInfo {
Review Comment:
I get that, my worry was about where to fill the information.
The `SuccessfulJob` and `PartitionLocation` objects are all created in
`execution_graph.rs` it seems. It appears weird to somehow forward the proxy
information all the way into the execution graph in order to be able to fill a
new field like `SuccessfulJob.flight_endpoint`
The alternative could be to clone & update the `SuccessfulJob` in the grpc
endpoint:
https://github.com/apache/datafusion-ballista/blob/118327ca424cf14e38e522b7f0af4ed9c6b3c8c3/ballista/scheduler/src/scheduler_server/grpc.rs#L450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
