jizezhang commented on issue #19055: URL: https://github.com/apache/datafusion/issues/19055#issuecomment-3671194579
Hey @BlakeOrth , I have one more question regarding the logic here https://github.com/apache/datafusion/blob/0a0416dbfe3c8fef7f39f370b755e8f46b0d9d73/datafusion/execution/src/cache/cache_manager.rs#L193-L200 It seems that if user creates a `ListFilesCache` with `ttl` set, e.g. `DefaultListFilesCache::new(1024, Some(Duration::from_secs(1))`, but does not set`CacheManagerConfig::list_files_cache_ttl`, this logic would unset `ttl` in the `list_files_cache`. Is that intended? e.g. should user always set `ttl` with `config.list_files_cache_ttl`? Thanks! (I saw your PR https://github.com/apache/datafusion/pull/19366 has some update on this part but this logic seems to remain the same, hence wanted to ask.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
