aaron-ang commented on code in PR #19367:
URL: https://github.com/apache/datafusion/pull/19367#discussion_r2641413208
##########
datafusion/ffi/tests/utils/mod.rs:
##########
@@ -15,14 +15,15 @@
// specific language governing permissions and limitations
// under the License.
-use std::sync::Arc;
-
-use datafusion::prelude::SessionContext;
-use datafusion_execution::TaskContextProvider;
-use datafusion_ffi::execution::FFI_TaskContextProvider;
-use datafusion_ffi::proto::logical_extension_codec::FFI_LogicalExtensionCodec;
-use datafusion_proto::logical_plan::DefaultLogicalExtensionCodec;
+#[cfg(feature = "integration-tests")]
+use {
+ datafusion::prelude::SessionContext,
datafusion_execution::TaskContextProvider,
+ datafusion_ffi::execution::FFI_TaskContextProvider,
+ datafusion_ffi::proto::logical_extension_codec::FFI_LogicalExtensionCodec,
+ datafusion_proto::logical_plan::DefaultLogicalExtensionCodec,
std::sync::Arc,
+};
+#[cfg(feature = "integration-tests")]
pub fn ctx_and_codec() -> (Arc<SessionContext>, FFI_LogicalExtensionCodec) {
let ctx = Arc::new(SessionContext::default());
let task_ctx_provider = Arc::clone(&ctx) as Arc<dyn TaskContextProvider>;
Review Comment:
got a lint warning in `rust-analyzer` about this unused function, so I added
the cfg flag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
