LiaCastaneda commented on code in PR #19546:
URL: https://github.com/apache/datafusion/pull/19546#discussion_r2651265704
##########
datafusion/core/tests/physical_optimizer/filter_pushdown/mod.rs:
##########
@@ -3512,3 +3512,97 @@ async fn
test_hashjoin_hash_table_pushdown_integer_keys() {
",
);
}
+
+#[tokio::test]
+async fn test_hashjoin_dynamic_filter_pushdown_not_used() {
Review Comment:
mmm, you’re right -- it would behave the same if we added this test in main.
I overlooked that. to test this end to end I was basically just printing the
strong count inside `is_used` and saw 1 when `.with_support(false)` and 2 when`
.with_support(true)` ... to test it we would have to make the `dynamic_filter`
param inside the `HashJoinExec` public and then check `is_used` after
optimization? but I don't think we want to make `dynamic_filter` public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
