adriangb commented on code in PR #19546:
URL: https://github.com/apache/datafusion/pull/19546#discussion_r2651279380
##########
datafusion/core/tests/physical_optimizer/filter_pushdown/mod.rs:
##########
@@ -3512,3 +3512,97 @@ async fn
test_hashjoin_hash_table_pushdown_integer_keys() {
",
);
}
+
+#[tokio::test]
+async fn test_hashjoin_dynamic_filter_pushdown_not_used() {
Review Comment:
I agree better to keep it private and just rely on the unit test. It's hard
to test that a transparent optimization does not kick in...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
