Jefffrey commented on code in PR #19711: URL: https://github.com/apache/datafusion/pull/19711#discussion_r2678429548
########## datafusion/sqllogictest/test_files/spark/datetime/add_months.slt: ########## @@ -15,13 +15,38 @@ # specific language governing permissions and limitations # under the License. Review Comment: Oh this is interesting; panicking is definitely not good, and I can reproduce that on main too: ```sql DataFusion CLI v51.0.0 > select '2016-07-30'::date + arrow_cast(2147483647::int, 'Interval(YearMonth)'); thread 'main' (15797910) panicked at /Users/jeffrey/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/chrono-0.4.42/src/naive/date/mod.rs:2005:41: `NaiveDate + Months` out of range note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` We should raise this as a separate issue as this should be erroring not panicking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
