sebbegg commented on code in PR #1351:
URL:
https://github.com/apache/datafusion-ballista/pull/1351#discussion_r2684919973
##########
ballista/scheduler/src/scheduler_server/grpc.rs:
##########
@@ -450,7 +450,22 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> SchedulerGrpc
let job_id = request.into_inner().job_id;
trace!("Received get_job_status request for job {}", job_id);
match self.state.task_manager.get_job_status(&job_id).await {
- Ok(status) => Ok(Response::new(GetJobStatusResult { status })),
+ Ok(status) => Ok(Response::new(GetJobStatusResult {
+ status,
+ flight_proxy: self
+ .state
+ .config
+ .advertise_flight_sql_endpoint
+ .clone()
+ .map(|s| match s {
+ s if s.is_empty() => format!(
Review Comment:
That's what happens - just felt that the "switch" was easier to implement on
scheduler side.
This way there's a bit less logic on the client side. Can move this though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
