milenkovicm commented on code in PR #1351:
URL:
https://github.com/apache/datafusion-ballista/pull/1351#discussion_r2685004927
##########
ballista/scheduler/src/scheduler_process.rs:
##########
@@ -131,7 +191,24 @@ pub async fn start_server(
) -> ballista_core::error::Result<()> {
info!("Ballista v{BALLISTA_VERSION} Scheduler listening on {address:?}");
let scheduler =
- create_scheduler::<LogicalPlanNode, PhysicalPlanNode>(cluster,
config).await?;
+ create_scheduler::<LogicalPlanNode, PhysicalPlanNode>(cluster,
config.clone())
+ .await?;
- start_grpc_service(address, scheduler).await
+ info!(
+ "advertise_flight_sql_endpoint: {:?}",
+ config.advertise_flight_sql_endpoint
+ );
+ match config.advertise_flight_sql_endpoint.clone() {
+ Some(s) if s != "" => {
Review Comment:
Yes, but you need to specify advertising address and configure it correctly,
which may be tricky in docker containers.
Suggestion would eliminate that as client already knows scheduler address.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
