huaxingao commented on code in PR #3237: URL: https://github.com/apache/datafusion-comet/pull/3237#discussion_r2714998845
########## common/src/main/java/org/apache/comet/parquet/AbstractColumnReader.java: ########## @@ -28,9 +28,11 @@ import org.apache.spark.sql.types.TimestampNTZType$; import org.apache.comet.CometConf; +import org.apache.comet.IcebergApi; import org.apache.comet.vector.CometVector; /** Base class for Comet Parquet column reader implementations. */ +@IcebergApi Review Comment: If we annotate the class with `@IcebergApi`, do we still need `@IcebergApi` in L66, L101 and L119? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
