andygrove commented on code in PR #3237: URL: https://github.com/apache/datafusion-comet/pull/3237#discussion_r2715003528
########## common/src/main/java/org/apache/comet/parquet/AbstractColumnReader.java: ########## @@ -28,9 +28,11 @@ import org.apache.spark.sql.types.TimestampNTZType$; import org.apache.comet.CometConf; +import org.apache.comet.IcebergApi; import org.apache.comet.vector.CometVector; /** Base class for Comet Parquet column reader implementations. */ +@IcebergApi Review Comment: Thanks for reviewing this @huaxingao. My plan was to annotate every class, method, and field referenced from Iceberg. Some methods are not referenced, so it would be safe to modify them without affecting Iceberg compatibility. The idea is that we know not to modify anything with the `@IcebergApi` annotation without careful consideration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
