Tushar7012 commented on PR #19975: URL: https://github.com/apache/datafusion/pull/19975#issuecomment-3796973737
Thanks for the detailed suggestions! To make sure I understand correctly: **Option 1**: Remove the builder usage entirely and store only the `u128` views directly in the `Entry` struct, updating the original view in-place. This eliminates the offset field and saves 8 bytes per value. **Option 2**: Keep the current struct without the `u128` view and instead expose views from the builder interface to access them directly by reference. I'm leaning towards **Option 1** as it seems more self-contained, but I want to confirm - for Option 1, would we be modifying the source `GenericByteViewBuilder` directly, or maintaining our own separate view storage? Let me know which approach you'd prefer and I'll implement it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
