Dandandan commented on code in PR #19975:
URL: https://github.com/apache/datafusion/pull/19975#discussion_r2726024934
##########
datafusion/physical-expr-common/src/binary_view_map.rs:
##########
@@ -124,8 +127,15 @@ where
/// Total size of the map in bytes
map_size: usize,
- /// Builder for output array
- builder: GenericByteViewBuilder<BinaryViewType>,
+ /// Views for all stored values (in insertion order)
+ views: Vec<u128>,
+ /// In-progress buffer for out-of-line string data
+ in_progress: Vec<u8>,
+ /// Completed buffers containing string data
+ completed: Vec<Buffer>,
+ /// Tracks null values (true = null)
+ nulls: Vec<bool>,
Review Comment:
This should use
https://arrow.apache.org/rust/arrow/array/struct.BooleanBufferBuilder.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
