Dandandan commented on PR #19975: URL: https://github.com/apache/datafusion/pull/19975#issuecomment-3797137251
> Updated! Changed `view_idx: usize` to `builder_idx: u32` to reduce memory overhead. > > This saves 4 bytes per entry on 64-bit systems while still supporting up to 4 billion distinct values - should be more than enough for practical use cases. > > Let me know if you'd like me to explore further optimizations or if this looks good! We need to either remove the buffer index (by getting it from the view), as it stands were still using 96 bits (128 - 32) more than originally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
