2010YOUY01 commented on issue #18319: URL: https://github.com/apache/datafusion/issues/18319#issuecomment-3798031798
How about calling it `simplify_func_op_constant()` for the existing `preimage()` in https://github.com/apache/datafusion/blob/4d63f8c9277705a6062625bc099151d0e4995692/datafusion/expr/src/udf.rs#L239 I agree it’s a bit hand-wavy, and `preimage` or `interval_containment` are more semantically precise. But if we introduce a new term, it might have two effects: - Some users may skip it and not bother trying to understand it, which can hurt adoption. - Others may fall into a rabbit hole: reading the Wikipedia page for “preimage” and then the ClickHouse paper just to figure out what it means (I did🤦🏼 I just figured it should be my personal issue). So while the terminology is accurate, it does add some cognitive overhead for something that is conceptually quite simple. Though I don't think it's a big deal, `preimage` is fine, given we already have great doc comment and example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
