Jefffrey commented on PR #19750: URL: https://github.com/apache/datafusion/pull/19750#issuecomment-3799942609
> For now, I kept the existing lightweight parser for extracting metadata from `main.rs` doc comments and just improved it where needed. As a follow-up PR, would it make sense to explore using a small parsing crate (e.g. `nom`) to make this logic more robust and easier to evolve, or is the preference to keep this part dependency-free? I'm not overly concerned about dependency footprint for this; we can always feature gate it so people running datafusion examples won't have it by default. My only concern is complexity in the code in the DataFusion repo. If we pull in `nom` but it leads to a more complex bin here then its probably not worth the tradeoff; but if it leads to simpler/more robust code here then that would be great. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
