cj-zhukov commented on PR #19750: URL: https://github.com/apache/datafusion/pull/19750#issuecomment-3803158136
@Jefffrey Thanks, that makes sense. I’ll keep this PR focused on improving the current implementation and avoid adding extra complexity here. For now, I think it’s best to keep the existing lightweight parser as-is and only make targeted improvements where needed. As follow-ups, I’m planning: - a small PR to unify the Prettier versions used in CI - a separate exploratory PR to evaluate a `nom`-based parser only if it clearly simplifies the parsing logic and improves robustness; otherwise, I agree it’s not worth the tradeoff Happy to adjust direction if you’d prefer a different approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
