masonh22 commented on code in PR #20040:
URL: https://github.com/apache/datafusion/pull/20040#discussion_r2738655026
##########
datafusion/physical-plan/src/filter_pushdown.rs:
##########
@@ -227,7 +227,7 @@ pub struct ChildPushdownResult {
/// [`ExecutionPlan::handle_child_pushdown_result`]:
crate::ExecutionPlan::handle_child_pushdown_result
#[derive(Debug, Clone)]
pub struct FilterPushdownPropagation<T> {
- /// What filters were pushed into the parent node.
+ /// Which parent filters were pushed down into this node's children.
Review Comment:
I'm not super familiar with the physical optimizer filter pushdown rule, but
`push_down_filters()` in `physical-optimizer/src/filter_pushdown.rs`
specifically distinguishes between "parent" filters and "self" filters, which
are both contained in `FilterPushdownPropagation::filters`.
So I think the comment should be "Which filters were pushed down..." instead
of "Which parent filters were pushed down..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
