maskit commented on code in PR #11673:
URL: https://github.com/apache/trafficserver/pull/11673#discussion_r1715632103
##########
src/traffic_server/traffic_server.cc:
##########
@@ -2215,6 +2215,21 @@ main(int /* argc ATS_UNUSED */, const char **argv)
REC_ReadConfigInteger(num_of_udp_threads, "proxy.config.udp.threads");
}
+ ats_scoped_str server_ports(255);
+ *server_ports = '\0';
+ REC_ReadConfigString(server_ports, "proxy.config.http.server_ports", 255);
+ bool quic_server_port = strstr(server_ports, "/quic/") != server_ports;
+
+#if TS_USE_QUIC == 0
+ if (quic_server_port) {
+ Fatal("proxy.config.http.server_ports listening for quic but
traffic_server wasn't built with quic support.");
+ }
+#endif
+
+ if (quic_server_port && num_of_udp_threads == 0) {
+ Fatal("proxy.config.http.server_ports listening for quic but
proxy.config.udp.threads is 0.");
Review Comment:
I'm not sure if we should use `Fatal`. Even port configuration error is just
a warning. It depends on the use case for sure, but QUIC being unavailable is
not the end of the world.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
