maskit commented on code in PR #11673:
URL: https://github.com/apache/trafficserver/pull/11673#discussion_r1716367712
##########
src/traffic_server/traffic_server.cc:
##########
@@ -2215,6 +2215,21 @@ main(int /* argc ATS_UNUSED */, const char **argv)
REC_ReadConfigInteger(num_of_udp_threads, "proxy.config.udp.threads");
}
+ ats_scoped_str server_ports(255);
+ *server_ports = '\0';
+ REC_ReadConfigString(server_ports, "proxy.config.http.server_ports", 255);
+ bool quic_server_port = strstr(server_ports, "/quic/") != server_ports;
+
+#if TS_USE_QUIC == 0
+ if (quic_server_port) {
+ Fatal("proxy.config.http.server_ports listening for quic but
traffic_server wasn't built with quic support.");
+ }
+#endif
+
+ if (quic_server_port && num_of_udp_threads == 0) {
+ Fatal("proxy.config.http.server_ports listening for quic but
proxy.config.udp.threads is 0.");
Review Comment:
How you catch misconfiguration and how ATS behave while configuration may be
wrong are different things. You could watch for a warning to catch
misconfiguration, or you could also watch for the UDP ports. Ideally you should
periodically send health check requests. Look at the code I mentioned above.
You can try to enable mptcp where mptcp is unavailable on the host and that
does not stop ATS. Lack of QUIC does not threaten the safety. QUIC can be
unavailable even with proper configuration if middle boxes block it. I still
think Fatal is too much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
