mattyw commented on code in PR #11673:
URL: https://github.com/apache/trafficserver/pull/11673#discussion_r1716246995
##########
src/traffic_server/traffic_server.cc:
##########
@@ -2215,6 +2215,21 @@ main(int /* argc ATS_UNUSED */, const char **argv)
REC_ReadConfigInteger(num_of_udp_threads, "proxy.config.udp.threads");
}
+ ats_scoped_str server_ports(255);
+ *server_ports = '\0';
+ REC_ReadConfigString(server_ports, "proxy.config.http.server_ports", 255);
+ bool quic_server_port = strstr(server_ports, "/quic/") != server_ports;
+
+#if TS_USE_QUIC == 0
+ if (quic_server_port) {
+ Fatal("proxy.config.http.server_ports listening for quic but
traffic_server wasn't built with quic support.");
+ }
+#endif
+
+ if (quic_server_port && num_of_udp_threads == 0) {
+ Fatal("proxy.config.http.server_ports listening for quic but
proxy.config.udp.threads is 0.");
Review Comment:
@maskit I think you might be right w.r.t warning - I bounced between fatal
and warning a few times before proposing.
> but QUIC being unavailable is not the end of the world.
Well, QUIC being unavailable when you've specifically asked ATS to serve
quic could be considered to be the end of the world - it would certainly be
surprising enough that I'd think we'd want to catch it sooner rather than later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
