Now you left me puzzled. Which menu items get duplicated by my reorganisation code? I tried to reproduce this with FlexiSheet and Bean and I am very sure that each item only appears once. In FlexiSheet I see an issue with the missing German language string for "Services" as there we have a German menu NIB, but otherwise everything is as expected. On the contrary your code is duplicating the quit menu item, but that isn't that bad, is it?
I am not sure about the separator items. I fully agree that they don't look great in our current drawing style. But the idea of structuring even a vertical a menu seems correct to me. We could try to replace the separator item drawing with something that just displays a vertical or horizontal line, this will make the menu item size computation a bid harder, but surely looks a lot better. Now we have two differing opinions. How to proceed from here? Are there any other points of view out there? Gregory Casamento wrote: > Differing philosophies is, I believe, the case. The reason I made the > change I did is because I felt it was important to do as little > transformation on the menu as possible since it would be easier to > predict where the items would end up. My code merely changes the > title, changes the name of one of the menus to Info (the first menu) > and adds "quit" item. > > I think I would feel better about the transformations you're doing in > your solution if it didn't duplicate the items and didn't include > separators in the main menu. I guess one thing we could do, in > general, is get rid of separator items altogether when displaying > vertically. I think putting menu transformation into a theme is > definitely a good idea. Different themes may have different ways of > organizing the menus. > > On an unrelated note, the solution to the duplicate items may be because > of alternate menu items. We should look into implementing that > sometime soon. _______________________________________________ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
