On 27 Feb 2009, at 09:03, Fred Kiefer wrote:
Now you left me puzzled. Which menu items get duplicated by my
reorganisation code? I tried to reproduce this with FlexiSheet and
Bean
and I am very sure that each item only appears once.
In FlexiSheet I see an issue with the missing German language string
for
"Services" as there we have a German menu NIB, but otherwise
everything
is as expected.
On the contrary your code is duplicating the quit menu item, but that
isn't that bad, is it?
I am not sure about the separator items. I fully agree that they don't
look great in our current drawing style. But the idea of structuring
even a vertical a menu seems correct to me. We could try to replace
the
separator item drawing with something that just displays a vertical or
horizontal line, this will make the menu item size computation a bid
harder, but surely looks a lot better.
Now we have two differing opinions. How to proceed from here? Are
there
any other points of view out there?
Well, I'm really not that familiar with the issue and don't really
understand the nature of the disagreement (assuming there is a real
disagreement and not just a misunderstanding).
The points I'm clear on are ...
1. duplication of code for handling menu rearrangement.
I think I wrote the original code for this for switching between
vertical and horizontal menus, but that' so long ago I don't remember
any detail. It sounds like Greg wrote different code to do a similar
job at the point when a nib is unarchived. I guess everyone things
there should be only one version.
2. Now that menus support spacer items, there is debate about how to
handle them ... I'm sure the original rearrangment code predates
spacers, so it's not surprising if it doesn't do a good job with them.
3. Some code has some other glitches in it that I don't understand/
follow?
On the issue of spacers ... I think we need to keep the spacer items
in the menu so that we retain all the information about them and can
therefore switch between horizontal and vertical layouts repeatedly
and consistently. However, horizontal and vertical menus should draw
them differently of course. A simple option would just be for the
drawing code to treat the as if they don't exist when drawing a
vertical menu ... ie make them occupy zero space on screen. Visually
this would probably be best.
_______________________________________________
Gnustep-dev mailing list
Gnustep-dev@gnu.org
http://lists.gnu.org/mailman/listinfo/gnustep-dev