Your code isn't duplicating the item. It's including items which are alternates which are (by definition) duplications of the items they serve as alternates for. :)
What I was saying is that I believe that we need to implement handling for alternate menu items. :) I am aware that my code duplicates the quit item. I had meant to change it to delete the one under Info so, in effect, it would move it. In general, I don't like the idea of doing a lot of manipulation on the menu because we have to guess what the developer was trying to achieve. GC On Fri, Feb 27, 2009 at 4:03 AM, Fred Kiefer <fredkie...@gmx.de> wrote: > Now you left me puzzled. Which menu items get duplicated by my > reorganisation code? I tried to reproduce this with FlexiSheet and Bean > and I am very sure that each item only appears once. > In FlexiSheet I see an issue with the missing German language string for > "Services" as there we have a German menu NIB, but otherwise everything > is as expected. > On the contrary your code is duplicating the quit menu item, but that > isn't that bad, is it? > > I am not sure about the separator items. I fully agree that they don't > look great in our current drawing style. But the idea of structuring > even a vertical a menu seems correct to me. We could try to replace the > separator item drawing with something that just displays a vertical or > horizontal line, this will make the menu item size computation a bid > harder, but surely looks a lot better. > > Now we have two differing opinions. How to proceed from here? Are there > any other points of view out there? > > Gregory Casamento wrote: > > Differing philosophies is, I believe, the case. The reason I made the > > change I did is because I felt it was important to do as little > > transformation on the menu as possible since it would be easier to > > predict where the items would end up. My code merely changes the > > title, changes the name of one of the menus to Info (the first menu) > > and adds "quit" item. > > > > I think I would feel better about the transformations you're doing in > > your solution if it didn't duplicate the items and didn't include > > separators in the main menu. I guess one thing we could do, in > > general, is get rid of separator items altogether when displaying > > vertically. I think putting menu transformation into a theme is > > definitely a good idea. Different themes may have different ways of > > organizing the menus. > > > > On an unrelated note, the solution to the duplicate items may be because > > of alternate menu items. We should look into implementing that > > sometime soon. > > -- Gregory Casamento Open Logic Corporation, Principal Consultant ## GNUstep Chief Maintainer yahoo/skype: greg_casamento, aol: gjcasa (240)274-9630 (Cell), (301)362-9640 (Home)
_______________________________________________ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
