This is looking very nice, I think the structure is great. We have a few issues to work on which are mentioned in in-line comments.
http://gwt-code-reviews.appspot.com/805/diff/1/5 File user/src/com/google/gwt/event/shared/GwtEvent.java (right): http://gwt-code-reviews.appspot.com/805/diff/1/5#newcode139 Line 139: /** Should this method be final? As we've regretted making onDetach not final. Also, I think you meant rely http://gwt-code-reviews.appspot.com/805/diff/1/9 File user/src/com/google/gwt/user/client/Event.java (right): http://gwt-code-reviews.appspot.com/805/diff/1/9#newcode187 Line 187: protected void kill() { can you document the method that requires access to kill here? http://gwt-code-reviews.appspot.com/805/diff/1/9#newcode482 Line 482: NativePreviewEvent event = new NativePreviewEvent(nativeEvent); I think we might want to recycle the native event here for efficiency. http://gwt-code-reviews.appspot.com/805/diff/1/11 File user/src/com/google/gwt/user/client/ui/DialogBox.java (left): http://gwt-code-reviews.appspot.com/805/diff/1/11#oldcode231 Line 231: As much as I'd really, really love to do this, I think backward compatibility forces us to deprecate the method rather then removing it. http://gwt-code-reviews.appspot.com/805/diff/1/11 File user/src/com/google/gwt/user/client/ui/DialogBox.java (right): http://gwt-code-reviews.appspot.com/805/diff/1/11#newcode392 Line 392: do we want to expose this? http://gwt-code-reviews.appspot.com/805/diff/1/13 File user/src/com/google/gwt/user/client/ui/MenuBar.java (left): http://gwt-code-reviews.appspot.com/805/diff/1/13#oldcode966 Line 966: public boolean onEventPreview(Event event) { See comments from DialogBox. http://gwt-code-reviews.appspot.com/805/diff/1/13 File user/src/com/google/gwt/user/client/ui/MenuBar.java (right): http://gwt-code-reviews.appspot.com/805/diff/1/13#newcode967 Line 967: protected void onPreviewNativeEvent(NativePreviewEvent event) { See comments from DialogBox. http://gwt-code-reviews.appspot.com/805/diff/1/12 File user/src/com/google/gwt/user/client/ui/PopupPanel.java (right): http://gwt-code-reviews.appspot.com/805/diff/1/12#newcode464 Line 464: */ Where is the onPreviewNativeEvent for this one? http://gwt-code-reviews.appspot.com/805/diff/1/3 File user/test/com/google/gwt/user/client/EventTest.java (right): http://gwt-code-reviews.appspot.com/805/diff/1/3#newcode26 Line 26: public class EventTest extends GWTTestCase { Nice Test! I think the only thing you need to add is the interactions of code that mixes the old and new styles. For example: Use adds a new style preview, then an old style preview. What order should they be evaluated in? http://gwt-code-reviews.appspot.com/805 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
