Would you be willing to drop a "before" and "after" example of the output for those of watching from the stands?
On Wed, Apr 22, 2009 at 1:55 PM, Freeland Abbott <fabb...@google.com> wrote: > Thanks. Typo fixed, submit at r5269. > > > On Tue, Apr 21, 2009 at 6:27 PM, Lex Spoon <sp...@google.com> wrote: > >> LGTM. There's a typo in ProblemReport: "accessir". >> >> -Lex >> >> >> On 4/21/09, Freeland Abbott <fabb...@google.com> wrote: >> > Here's the promised follow-on to my earlier, fixing the subtype logging >> to >> > be a subtree logger. >> > >> > I'm still bothered by the multiple entries for "E extends >> java.lang.Object", >> > but I'm not sure which is the better way to fix it... I think I would >> like >> > to change JType constructors and/or .equals, to generalize to e.g. "id1 >> > extends java.lang.Object" or "id1 extends Map<id2 extends KeyType, id3 >> > implements ValType>", but I'm not sure how such a change might impact >> other >> > uses of JType and children elsewhere... I would like to think it was >> > beneficial. >> > >> > The other, more localized approach would be to change the TIC map key >> from >> > JClassType to String, and to do the identifier-abstraction as types were >> > stringified in STOB, only. Thoughts? >> > >> > >> > >> > > > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
