>From this patch (the bigger impact is my earlier one, which already had at least the "after" form thrashed on), the new, sublogger-using format is: [java] Compiling module com.google.gwt.sample.broken.Broken [java] Scanning for additional dependencies: file:/C:/Documents%20and%20Settings/fabbott/My%20Documents/GWT/gwt-trunk/samples/broken/src/com/google/gwt/sample/broken/client/BrokenRpc.java [java] Computing all possible rebind results for 'com.google.gwt.sample.broken.client.BrokenRpcService' [java] Rebinding com.google.gwt.sample.broken.client.BrokenRpcService [java] Invoking <generate-with class='com.google.gwt.user.rebind.rpc.ServiceInterfaceProxyGenerator'/> [java] Generating client proxy for remote service interface 'com.google.gwt.sample.broken.client.BrokenRpcService' [java] [ERROR] com.google.gwt.sample.broken.client.AbstractTopInterface has no available instantiable subtypes. (reached via com.google.gwt.sample.broken.client.AbstractTopInterface) [java] [ERROR] subtype com.google.gwt.sample.broken.client.AbstractTopInterface is not instantiable [java] [ERROR] subtype com.google.gwt.sample.broken.client.AbstractSerializableChildClass is not instantiable [java] [ERROR] subtype com.google.gwt.sample.broken.client.ConcreteSerializableChildClassNoCtor is not default instantiable (it must have a zero-argument constructor or no constructors at all) and has no custom serializer. (reached via com.google.gwt.sample.broken.client.AbstractTopInterface) [java] [ERROR] subtype com.google.gwt.sample.broken.client.AbstractNonSerializableClass is not instantiable [java] [ERROR] subtype com.google.gwt.sample.broken.client.AbstractSerializableClass is not instantiable [java] [ERROR] com.google.gwt.sample.broken.client.ConcreteSerializableChildClassNoCtor is not default instantiable (it must have a zero-argument constructor or no constructors at all) and has no custom serializer. (reached via com.google.gwt.sample.broken.client.AbstractTopInterface) [java] [ERROR] Errors in 'file:/C:/Documents%20and%20Settings/fabbott/My%20Documents/GWT/gwt-trunk/samples/broken/src/com/google/gwt/sample/broken/client/BrokenRpc.java' [java] [ERROR] Line 144: Failed to resolve 'com.google.gwt.sample.broken.client.BrokenRpcService' via deferred binding [java] [ERROR] Cannot proceed due to previous errors
And the before, in which the sub-entries were glommed into the top-level one as a multi-line entry (because there was no Problem structure, merely a single String entry), was: [java] Compiling module com.google.gwt.sample.broken.Broken [java] Scanning for additional dependencies: file:/C:/Documents%20and%20Settings/fabbott/My%20Documents/GWT/gwt-trunk/samples/broken/src/com/google/gwt/sample/broken/client/BrokenRpc.java [java] Computing all possible rebind results for 'com.google.gwt.sample.broken.client.BrokenRpcService' [java] Rebinding com.google.gwt.sample.broken.client.BrokenRpcService [java] Invoking <generate-with class='com.google.gwt.user.rebind.rpc.ServiceInterfaceProxyGenerator'/> [java] Generating client proxy for remote service interface 'com.google.gwt.sample.broken.client.BrokenRpcService' [java] [ERROR] com.google.gwt.sample.broken.client.AbstractTopInterface has no available instantiable subtypes. (reached via com.google.gwt.sample.broken.client.AbstractTopInterface) [java] subtype com.google.gwt.sample.broken.client.AbstractTopInterface is not instantiable [java] subtype com.google.gwt.sample.broken.client.AbstractSerializableChildClass is not instantiable [java] subtype com.google.gwt.sample.broken.client.ConcreteSerializableChildClassNoCtor is not default instantiable (it must have a zero-argument constructor or no constructors at all) and has no custom serializer. (reached via com.google.gwt.sample.broken.client.AbstractTopInterface) [java] subtype com.google.gwt.sample.broken.client.AbstractNonSerializableClass is not instantiable [java] subtype com.google.gwt.sample.broken.client.AbstractSerializableClass is not instantiable [java] [ERROR] com.google.gwt.sample.broken.client.ConcreteSerializableChildClassNoCtor is not default instantiable (it must have a zero-argument constructor or no constructors at all) and has no custom serializer. (reached via com.google.gwt.sample.broken.client.AbstractTopInterface) [java] [ERROR] Errors in 'file:/C:/Documents%20and%20Settings/fabbott/My%20Documents/GWT/gwt-trunk/samples/broken/src/com/google/gwt/sample/broken/client/BrokenRpc.java' [java] [ERROR] Line 144: Failed to resolve 'com.google.gwt.sample.broken.client.BrokenRpcService' via deferred binding [java] [ERROR] Cannot proceed due to previous errors On Wed, Apr 22, 2009 at 1:58 PM, Bruce Johnson <br...@google.com> wrote: > Would you be willing to drop a "before" and "after" example of the output > for those of watching from the stands? > > > On Wed, Apr 22, 2009 at 1:55 PM, Freeland Abbott <fabb...@google.com>wrote: > >> Thanks. Typo fixed, submit at r5269. >> >> >> On Tue, Apr 21, 2009 at 6:27 PM, Lex Spoon <sp...@google.com> wrote: >> >>> LGTM. There's a typo in ProblemReport: "accessir". >>> >>> -Lex >>> >>> >>> On 4/21/09, Freeland Abbott <fabb...@google.com> wrote: >>> > Here's the promised follow-on to my earlier, fixing the subtype logging >>> to >>> > be a subtree logger. >>> > >>> > I'm still bothered by the multiple entries for "E extends >>> java.lang.Object", >>> > but I'm not sure which is the better way to fix it... I think I would >>> like >>> > to change JType constructors and/or .equals, to generalize to e.g. "id1 >>> > extends java.lang.Object" or "id1 extends Map<id2 extends KeyType, id3 >>> > implements ValType>", but I'm not sure how such a change might impact >>> other >>> > uses of JType and children elsewhere... I would like to think it was >>> > beneficial. >>> > >>> > The other, more localized approach would be to change the TIC map key >>> from >>> > JClassType to String, and to do the identifier-abstraction as types >>> were >>> > stringified in STOB, only. Thoughts? >>> > >>> > >>> > >>> >> >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---