Thanks, Kathrin! There are few questions inline before I commit it.....
http://gwt-code-reviews.appspot.com/33843/diff/1/6 File tools/soyc-vis/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java (right): http://gwt-code-reviews.appspot.com/33843/diff/1/6#newcode629 Line 629: if (i == numSplitPoints + 1 && numSplitPoints == 0) { I like that better and will change it. http://gwt-code-reviews.appspot.com/33843/diff/1/2 File tools/soyc-vis/src/com/google/gwt/soyc/Settings.java (right): http://gwt-code-reviews.appspot.com/33843/diff/1/2#newcode120 Line 120: throw new ArgumentListException("The -resources option is required"); Yes, and it is. The caller already prints a usage message if there is an ArgumentListException. In this case, the usage message was printed twice. http://gwt-code-reviews.appspot.com/33843/diff/1/3 File tools/soyc-vis/src/com/google/gwt/soyc/SoycDashboard.java (left): http://gwt-code-reviews.appspot.com/33843/diff/1/3#oldcode174 Line 174: return unescaped; Strange indeed. I have done some digging, and it looks like this method was never called. It comes in in revision 4221 along with the initial committed version of the SOYC dashboard, and it isn't called in that revision. If it were called, then the issue Dan brings up I agree looks likely to be a problem. There would be extra '\\' characters in the output. Additionally, I think the "&" unescape should come last, just like it it comes first when escaping. Shall I go ahead and remove it in this patch? We can add it back later if we need, but no specific problem has been identified as yet. http://gwt-code-reviews.appspot.com/33843 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
