Thanks Scott. Commited the changes at r5844 with a fix the first thing and a TODO for the second thing.
On Thu, Jul 30, 2009 at 10:48 AM, <sco...@google.com> wrote: > LGTM with nits. > > > http://gwt-code-reviews.appspot.com/54809/diff/1096/1130 > File user/src/com/google/gwt/junit/JUnitShell.java (right): > > http://gwt-code-reviews.appspot.com/54809/diff/1096/1130#newcode220 > Line 220: + "e.g. IE6,IE7,FF2,FF3..."; > Could the exact list be gotten from RunStyleHtmlUnit? Then you don't > need to update this message if the set of browsers changes. > > http://gwt-code-reviews.appspot.com/54809/diff/1096/1129 > File user/src/com/google/gwt/junit/RunStyleHtmlUnit.java (right): > > http://gwt-code-reviews.appspot.com/54809/diff/1096/1129#newcode149 > Line 149: threads.add(hut); > Is there any way to, say, pause here waiting for the other thread to get > to an "okay" state that would could call a successful launch? Might be > nice to detect & report errors early. > > > http://gwt-code-reviews.appspot.com/54809 > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
