Looks convenient, but I have a few questions/comments. 1) What happens if the module returned by getModuleName() already specifies a fix value for a given property? More generally, how should one think about how these annotations dovetail with the settings in the module config?
2) The terminology is different than we've used in the past. Granted, we haven't been very consistent with the term for "deferred binding properties" (e.g. we've also called them "client properties"), but we've never called them "module parameters". I know that doesn't make for a nice annotation name, but I do want to avoid introducing yet another name for the same concept. 3) Would these annotations apply to the benchmarking subsystem? Should they? Could they? On Fri, Sep 25, 2009 at 12:09 PM, John LaBanca <jlaba...@google.com> wrote: > Patch courtesy of pmuetschard. > > We propose adding the annotation @WithModuleParameters to specify deferred > binding properties on specific test methods, as per this patch: > http://gwt-code-reviews.appspot.com/71801/show > > For a specific example, see the test file in the patch: > http://gwt-code-reviews.appspot.com/71801/patch/45/49 > > This patch is pretty cool, but there are a couple of important items to > consider: > 1. Using these annotations increases the number of compilations. In the > example above, the single test class would require two compilations (one for > each test case). If the test case had a third, non-annotated method, the > number of compilations would be three. This is a natural side effect that > would be true even if the user creates a separate test case with a separate > test module for each parameter combination. > > 2. As the patch stands now, @WithModuleParameters is NOT inherited, so if a > subclass overrides a test method, the annotations will not apply. I > suggest we add t...@inherited tag to the definition so that overriding > subclasses do inherit the annotation. > > Thanks, > John LaBanca > jlaba...@google.com > > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
