http://gwt-code-reviews.appspot.com/863801/diff/32001/33004 File samples/common.ant.xml (right):
http://gwt-code-reviews.appspot.com/863801/diff/32001/33004#newcode100 samples/common.ant.xml:100: </classpath> On 2010/10/04 20:52:02, bobv wrote:
Low priority: Can you extract this classpath as an ant environment
variable so
it's not buried down in the target definition?
I will do that in a separate CL. They way I want to do it will touch all the sample build.xml's http://gwt-code-reviews.appspot.com/863801/diff/32001/33005 File samples/validation/build.xml (right): http://gwt-code-reviews.appspot.com/863801/diff/32001/33005#newcode2 samples/validation/build.xml:2: <!-- Must be compiled using jdk 1.6, because hibernate needs jaxb --> Wont't compile without. I have added all the needed jdk1.5 jars. http://gwt-code-reviews.appspot.com/863801/diff/32001/33006 File samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml (right): http://gwt-code-reviews.appspot.com/863801/diff/32001/33006#newcode20 samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml:20: <inherits name='org.hibernate.validator.HibernateValidator'/> On 2010/10/04 20:52:02, bobv wrote:
Since HibernateValidator also includes the Validation package, I think
you
should drop the redundant import to reduce the huh? factor in the
sample app. Done. http://gwt-code-reviews.appspot.com/863801/diff/32001/33015 File user/build.xml (right): http://gwt-code-reviews.appspot.com/863801/diff/32001/33015#newcode67 user/build.xml:67: <pathelement location="${gwt.tools.lib}/hibernate/validator/hibernate-validator-4.1.0.Final-sources.jar" /> On 2010/10/04 20:52:02, bobv wrote:
Indentation looks off, could just be rietveld.
Done. http://gwt-code-reviews.appspot.com/863801/diff/32001/33025 File user/src/org/hibernate/validator/HibernateValidator.gwt.xml (right): http://gwt-code-reviews.appspot.com/863801/diff/32001/33025#newcode1 user/src/org/hibernate/validator/HibernateValidator.gwt.xml:1: <?xml version="1.0" encoding="UTF-8"?> On 2010/10/04 20:52:02, bobv wrote:
Add a comment in this file explaining when/how to import this module
and a
readme file in same directory explaining why these files exist and any maintenance directions.
Done. http://gwt-code-reviews.appspot.com/863801/diff/32001/33044 File user/test/com/google/gwt/validation/example/client/AuthorTest.java (right): http://gwt-code-reviews.appspot.com/863801/diff/32001/33044#newcode53 user/test/com/google/gwt/validation/example/client/AuthorTest.java:53: // public void testNotDefaultValidtor_EmptyNotDefualt() throws Exception { On 2010/10/04 20:52:02, bobv wrote:
Instead of commenting out the code rename the method to
disabled_testXyzzy just
to make sure the code doesn't rot from a compilation standpoint.
This code does not compile yet. http://gwt-code-reviews.appspot.com/863801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
