LGTM
http://gwt-code-reviews.appspot.com/1082801/diff/50001/51001 File user/src/com/google/gwt/canvas/Canvas.gwt.xml (right): http://gwt-code-reviews.appspot.com/1082801/diff/50001/51001#newcode17 user/src/com/google/gwt/canvas/Canvas.gwt.xml:17: <inherits name="com.google.gwt.canvas.dom.DOM"/> I think we need to inherit User here because Canvas extends FocusWidget. http://gwt-code-reviews.appspot.com/1082801/diff/50001/51003 File user/src/com/google/gwt/canvas/dom/DOM.gwt.xml (right): http://gwt-code-reviews.appspot.com/1082801/diff/50001/51003#newcode17 user/src/com/google/gwt/canvas/dom/DOM.gwt.xml:17: <inherits name="com.google.gwt.user.User"/> Does this really need User? I think it just need com.google.gwt.dom.DOM. Not sure though. http://gwt-code-reviews.appspot.com/1082801/diff/50001/51004 File user/src/com/google/gwt/canvas/dom/client/CanvasGradient.java (right): http://gwt-code-reviews.appspot.com/1082801/diff/50001/51004#newcode35 user/src/com/google/gwt/canvas/dom/client/CanvasGradient.java:35: public final native void addColorStop(float offset, String color) /*-{ use value().addColorStop() http://gwt-code-reviews.appspot.com/1082801/diff/50001/51008 File user/src/com/google/gwt/canvas/dom/client/Context2d.java (right): http://gwt-code-reviews.appspot.com/1082801/diff/50001/51008#newcode304 user/src/com/google/gwt/canvas/dom/client/Context2d.java:304: return [this.createLinearGradient(x0, y0, x1, y1)]; JavaDoc this zaniness. http://gwt-code-reviews.appspot.com/1082801/diff/50001/51009 File user/src/com/google/gwt/canvas/dom/client/CssColor.java (right): http://gwt-code-reviews.appspot.com/1082801/diff/50001/51009#newcode59 user/src/com/google/gwt/canvas/dom/client/CssColor.java:59: public final native String value() /*-{ Move value() up to FillStrokeStyle and JavaDoc why it works the way it does. http://gwt-code-reviews.appspot.com/1082801/diff/50001/51010 File user/src/com/google/gwt/canvas/dom/client/FillStrokeStyle.java (right): http://gwt-code-reviews.appspot.com/1082801/diff/50001/51010#newcode29 user/src/com/google/gwt/canvas/dom/client/FillStrokeStyle.java:29: public final native int getType() /*-{ If you move value() from CssColor to here, you can get rid of the isScript() check. var value = value(); if (typeof(value) == "string") etc... http://gwt-code-reviews.appspot.com/1082801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
