LGTM

http://gwt-code-reviews.appspot.com/1082801/diff/101001/102006
File user/src/com/google/gwt/canvas/dom/client/CanvasPixelArray.java
(right):

http://gwt-code-reviews.appspot.com/1082801/diff/101001/102006#newcode54
user/src/com/google/gwt/canvas/dom/client/CanvasPixelArray.java:54: *
Most browsers will clamp this value to the range 0...255 that is not
enforced here.
"Most browser will clamp this value to the range 0...255, but that is
not enforced by this implementation.

http://gwt-code-reviews.appspot.com/1082801/diff/101001/102006#newcode57
user/src/com/google/gwt/canvas/dom/client/CanvasPixelArray.java:57:
this[i] = value;
Add comment explaining why we don't limit the range:
// FF35 doesn't clamp the range. We don't clamp it manually to maximize
performance.

http://gwt-code-reviews.appspot.com/1082801/diff/101001/102020
File user/test/com/google/gwt/canvas/dom/client/Context2dTest.java
(right):

http://gwt-code-reviews.appspot.com/1082801/diff/101001/102020#newcode242
user/test/com/google/gwt/canvas/dom/client/Context2dTest.java:242: //
are disabled for FF 3.0 and before.
From what I read, this only happens if the image is from a  different
domain than the page.  Still, I don't know of any way around it.

http://gwt-code-reviews.appspot.com/1082801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to