http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010 File user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java (right):
http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010#newcode66 user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java:66: * resolvedResourceUrl has changed. This last sentence isn't clear. Is the point of the extra resourceName parameter to handle the automatically-generated resource types from UiBinder? http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010#newcode72 user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java:72: * @param resolvedResourceUrl Parameter descriptions. http://gwt-code-reviews.appspot.com/1236801/diff/110014/111011 File user/src/com/google/gwt/resources/ext/ResourceContext.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/110014/111011#newcode158 user/src/com/google/gwt/resources/ext/ResourceContext.java:158: URL[] getResourcesForMethod(JMethod method); This is no longer used in this patch. Any reason to keep it, since RGU.findResources() can handle caching of JMethod->URL resolution? http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014 File user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode201 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:201: private final Set<String> axes; Sort fields alphabetically unless there's a reason to do otherwise. http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode211 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:211: this.axesLocked = false; Unnecessary. http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode231 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:231: if (!canBeCacheable) { With the if call before getConfigurationPropertyName(), this method will have different error behavior if caching is or is not enabled. http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode306 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:306: if (!(type instanceof JRealClassType)) { Reverse the then-else clauses to avoid a negative test. http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode318 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:318: // no further permutation axes can be added after this is called Make javadoc. http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode649 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:649: } catch (RuntimeException ruEx) { Why? http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode668 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:668: /*checkDependentResource Old comment? http://gwt-code-reviews.appspot.com/1236801/diff/110014/111015 File user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/110014/111015#newcode57 user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java:57: private Map<JMethod, URL[]> foundResourceMap = new HashMap<JMethod, URL[]>(); Still needed? http://gwt-code-reviews.appspot.com/1236801/diff/110014/111015#newcode58 user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java:58: private ClientBundleRequirements requirements = null; Sort. http://gwt-code-reviews.appspot.com/1236801/diff/110014/111017 File user/src/com/google/gwt/resources/rg/BundleResourceGenerator.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/110014/111017#newcode41 user/src/com/google/gwt/resources/rg/BundleResourceGenerator.java:41: + method.getReturnType().getQualifiedSourceName() + ".class)"; Does this need to add a requirement on the sub-bundle type, or is that an implicit dependency of the top-level bundle? http://gwt-code-reviews.appspot.com/1236801/diff/110014/111018 File user/src/com/google/gwt/resources/rg/CssResourceGenerator.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/110014/111018#newcode134 user/src/com/google/gwt/resources/rg/CssResourceGenerator.java:134: private static final String KEY_OBFUSCATION_PREFIX = "CssResource.obfuscationPrefix"; Sort. http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
