http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010 File user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java (right):
http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010#newcode66 user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java:66: * resolvedResourceUrl has changed. On 2011/02/07 15:55:23, bobv wrote:
This last sentence isn't clear. Is the point of the extra
resourceName
parameter to handle the automatically-generated resource types from
UiBinder? Done. http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010#newcode72 user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java:72: * @param resolvedResourceUrl On 2011/02/07 15:55:23, bobv wrote:
Parameter descriptions.
Done. http://gwt-code-reviews.appspot.com/1236801/diff/110014/111011 File user/src/com/google/gwt/resources/ext/ResourceContext.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/110014/111011#newcode158 user/src/com/google/gwt/resources/ext/ResourceContext.java:158: URL[] getResourcesForMethod(JMethod method); removed http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014 File user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode201 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:201: private final Set<String> axes; On 2011/02/07 15:55:23, bobv wrote:
Sort fields alphabetically unless there's a reason to do otherwise.
Done. http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode211 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:211: this.axesLocked = false; On 2011/02/07 15:55:23, bobv wrote:
Unnecessary.
Done. http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode231 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:231: if (!canBeCacheable) { We don't want to change the behavior, or incur unnecessary overhead, if caching is not enabled or available. One would expect different exception behavior when different code paths are taken, no? http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode306 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:306: if (!(type instanceof JRealClassType)) { On 2011/02/07 15:55:23, bobv wrote:
Reverse the then-else clauses to avoid a negative test.
Done. http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode318 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:318: // no further permutation axes can be added after this is called I made it a comment above the method http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode649 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:649: } catch (RuntimeException ruEx) { Added explanation http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode668 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:668: /*checkDependentResource Removed http://gwt-code-reviews.appspot.com/1236801/diff/110014/111015 File user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/110014/111015#newcode57 user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java:57: private Map<JMethod, URL[]> foundResourceMap = new HashMap<JMethod, URL[]>(); Removed http://gwt-code-reviews.appspot.com/1236801/diff/110014/111015#newcode58 user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java:58: private ClientBundleRequirements requirements = null; On 2011/02/07 15:55:23, bobv wrote:
Sort.
Done. http://gwt-code-reviews.appspot.com/1236801/diff/110014/111017 File user/src/com/google/gwt/resources/rg/BundleResourceGenerator.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/110014/111017#newcode41 user/src/com/google/gwt/resources/rg/BundleResourceGenerator.java:41: + method.getReturnType().getQualifiedSourceName() + ".class)"; I'm not sure I understand completely. The top-level bundle type (and it's type hierarchy) will be added as a dependency. Sub-bundle types (which will get separately generated via the subsequent GWT.create call), will get addressed at the time that their generators run. Is there something else I'm not thinking of here? http://gwt-code-reviews.appspot.com/1236801/diff/110014/111018 File user/src/com/google/gwt/resources/rg/CssResourceGenerator.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/110014/111018#newcode134 user/src/com/google/gwt/resources/rg/CssResourceGenerator.java:134: private static final String KEY_OBFUSCATION_PREFIX = "CssResource.obfuscationPrefix"; On 2011/02/07 15:55:23, bobv wrote:
Sort.
Done. http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
