LGTM
http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014 File user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode231 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:231: if (!canBeCacheable) { On 2011/02/07 20:32:10, jbrosenberg wrote:
We don't want to change the behavior, or incur unnecessary overhead,
if caching
is not enabled or available. One would expect different exception
behavior when
different code paths are taken, no?
What wouldn't be expected is inconsistent input validation, especially for an API that appears to mirror an existing one (addPermutationAxis()) that always validates. http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
