http://gwt-code-reviews.appspot.com/1385810/diff/4002/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java File dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java (right):
http://gwt-code-reviews.appspot.com/1385810/diff/4002/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java#newcode194 dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java:194: private static void addUnitsToVisit(Map<String, CompilationUnit> unitMap, String typeName, 'addUnitToVisit' since it only adds 1 unit? http://gwt-code-reviews.appspot.com/1385810/diff/4002/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right): http://gwt-code-reviews.appspot.com/1385810/diff/4002/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java#newcode278 dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java:278: return buildFrom(logger, resources, null, true); Adding the boolean here probably wouldn't be nearly as much churn as ModuleDef.getCompilationState(), but if not, default suppression surprised me since it's the opposite of ModuleDef's default. http://gwt-code-reviews.appspot.com/1385810/diff/4002/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java (right): http://gwt-code-reviews.appspot.com/1385810/diff/4002/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java#newcode854 dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:854: new String(cud.getMainTypeName()), false); I can't get my head around this. If there's a valid file on the file system you can read (Util.readFileAsString), those are the exact cases that *won't* dump to disk. The dump to disk is for generated units, which by definition you can't read the source off disk. What am I missing? http://gwt-code-reviews.appspot.com/1385810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
