Thanks for the review; I'll incorporate most of it, so just focusing on this:
I.e. in updateListBox: Object key = keyProvider.getKey(value); if (index == null) { if (value != null) { addValue(value); index = valueKeyToIndex.get(key); assert index != null; } else { index = -1; } } getListBox().setSelectedIndex(index);
Hm. Yeah, I think I like this better, but I think it's a larger change as now users that had explicitly called setValue(null) --> a new empty row, won't see an empty row anymore. I do think it makes sense though. I will try it out with IE6. Rajeev, what do you think about no longer implicitly adding an empty row just to handle the null case (but using selectedIndex=-1 for it instead)? http://gwt-code-reviews.appspot.com/1619803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors