On Thu, Nov 22, 2012 at 9:41 AM, Thomas Broyer <t.bro...@gmail.com> wrote:

> >>    1. CRITICAL: java.lang.NoClassDefFoundError:
> >>    com/google/gwt/core/client/GWTBridge
> >>    https://code.google.com/p/google-web-toolkit/issues/detail?id=7527
> >>
> > Regarding the server calling client issue -- is it correct that the
> client
> > code is actually forked via super-source so that it works properly on
> > client or server?
>
> I believe so yes. Not sure all those classes have super-sources but I
> don't think it's a problem either.
>
> > If so, maybe we should rename it to shared,
>
> That'd be a breaking change. These are mostly internals, but I bet at
> least a few people are using c.g.g.user.client.rpc.core.* classes in
> their own custom field serializers, so I guess it's too late for a
> rename (and I'm not in the mood to introduce an indirection where all
> (deprecated) *.client.* classes would just delegate to their
> *.shared.* counterparts).


It doesn't seem that hard to add the redirection (and it should impose only
minimal overhead in those cases, just the class ids), and it avoids
indefinitely using *.client.* code on the server.  It should be the case
that if you ever see server code referencing client classes it is an error,
and if we leave things like this around then we won't ever get away from it.

Also, regarding breaking changes, what exactly is the criteria for what is
acceptable?  You have an outstanding change that would break any code that
previously passed a Target to something accepting HasText, so I'm not sure
I know what level of breaking change is acceptable and what benefit is
required.

-- 
John A. Tamplin

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to