Seems fine. (I'll take care of these nits.)
http://gwt-code-reviews.appspot.com/1587803/diff/10006/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java File user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java (right): http://gwt-code-reviews.appspot.com/1587803/diff/10006/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java#newcode71 user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java:71: public Q getValue() { @Override? http://gwt-code-reviews.appspot.com/1587803/diff/10006/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java#newcode75 user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java:75: public void setIndex(int index) { Doesn't need to be public since we only call it from HasDataEditorSource.setIndex. http://gwt-code-reviews.appspot.com/1587803/diff/10006/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java#newcode81 user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java:81: public void setValue(Q value) { @Override? http://gwt-code-reviews.appspot.com/1587803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
