Ray Cromwell has posted comments on this change.
Change subject: Fix non deterministic behaviour in TypeTightener.
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
I'm ok with the solution, but it leaves me wonder if we should opt with
explicit sorting instead of implicit set ordering.
....................................................
File dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
Line 488: * In particular generalizeTypes({I,A,C}) = I and
generalizeTypes({A,C,I}) = O.
Interesting, and somewhat scary. I wonder if we should impose some kind of
sort order. I think in general, we'd prefer O in this case, since a
concrete implementor would be a tighter bounder than an interface I think,
in terms of further optimizations?
--
To view, visit https://gwt-review.googlesource.com/2530
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I51f551dbf2d5362f710d4e1321f7b7bb35445608
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Ray Cromwell <cromwell...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
