Brian Slesinsky has posted comments on this change.
Change subject: Fix non deterministic behaviour in TypeTightener.
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Seems fine.
I was wondering whether we could replace LinkedHashSet with a plain List
since it looks like we just iterate over the sets. However, I think we
still need duplicate removal.
....................................................
Commit Message
Line 9: JProgram.generalizeTyeps(Collection<JType>) depends on the ordering
of the
"generalizeTypes"
Line 12: Made all HashSets that could flown into the aforementioned funcion
into
s/could flown/could flow/
s/funcion/function/
....................................................
File dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
Line 472: * NOTE: Ideally we would like to return the least upper bound
but it does not exits as
s/exits/exist/
Thanks for the clear explanation.
--
To view, visit https://gwt-review.googlesource.com/2530
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I51f551dbf2d5362f710d4e1321f7b7bb35445608
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Ray Cromwell <cromwell...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
