Brian Slesinsky has posted comments on this change.
Change subject: Fix non deterministic behaviour in TypeTightener.
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Seems basically okay but I didn't verify anything about when it's safe to
skip removing duplicates.
....................................................
File dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java
Line 841: private final Map<JVariable, List<JExpression>> assignments =
Maybe add javadoc explaining what each of these variables contains?
--
To view, visit https://gwt-review.googlesource.com/2530
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I51f551dbf2d5362f710d4e1321f7b7bb35445608
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Ray Cromwell <cromwell...@google.com>
Gerrit-Reviewer: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
