Goktug Gokdogan has posted comments on this change.

Change subject: Introduces generic Composite widgets.
......................................................................


Patch Set 4:

It doesn't work with UIBinder because you are changing the expected semantics of a widget. So even without UIBinder case, this is still how it suppose to work.

You need to think in term of consumption. If a composite has multiple focusable objects and wants to expose focus API, it has different options depending on the specific scenario. In a SuggestBox case, it would use the input the field as the logical reference for Focus from outside point of view even though autocomplete popup might be focusable.

For another widget that has multiple inputs and it really wants to really provide a Focus API, it has two options. Either it needs to synthesize it in a way that it looks like a single focusable piece from outside or it will need implement additional APIs in addition to HasFocus.

Being said that, I don't ever remember trying to implement Focus interface on a UIBinder composed view. Focus concept is more intended to be used with widgets in contrast to a complex view.

--
To view, visit https://gwt-review.googlesource.com/2582
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Jens Nehlmeier <jens.nehlme...@gmail.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@gwtproject.org>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to