Goktug Gokdogan has posted comments on this change.
Change subject: Introduces generic Composite widgets.
......................................................................
Patch Set 3:
(5 comments)
....................................................
File user/src/com/google/gwt/user/client/ui/Composite.java
Line 32: * calls to the wrapped widget (e.g. HasWidgets APIs). Also,
alternatively, subclasses can choose a
Done
Line 36: * <h3>Example</h3> {@example
com.google.gwt.examples.CompositeExample}
Yes. I'll send another patch that converts all trivial Composite usages to
Composite<Widget>.
Line 127: * Provides subclasses access to the widget that higher level
APIs are
I was keeping the wording similar with getWidget. Will update both.
Line 140: *
Done
....................................................
File user/src/com/google/gwt/user/client/ui/FocusComposite.java
Line 127: return getDelegate().addDoubleClickHandler(handler);
For this to work as expected (i.e. source == composite and ideally with
possible custom addXXXHandler impls at delegate), I will need to create
anonymous class that changes the source for each handler type; I'm not sure
that is what we want.
I will think little bit more on alternatives but I'm not very optimistic
about a good solution...
--
To view, visit https://gwt-review.googlesource.com/2582
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Jens Nehlmeier <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
