Hello Ray Cromwell, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

    https://gwt-review.googlesource.com/3030

to look at the new patch set (#7).

Change subject: Fix non-final field initializers running before the super cstr.
......................................................................

Fix non-final field initializers running before the super cstr.

Previously, any field with an initializer would get assigned at
the top-level scope, before any cstrs had run.

However, this does not match the JVM behavior, which is that final fields behave
this way, but non-field fields have their type's default value assigned when
super cstrs run, and then only later in their cstr are assigned to the initializer.

Bug: issue 380
Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918
---
M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
M user/test/com/google/gwt/dev/jjs/test/CompilerTest.java
A user/test/com/google/gwt/dev/jjs/test/FieldInitOrderBase.java
A user/test/com/google/gwt/dev/jjs/test/FieldInitOrderChild.java
4 files changed, 83 insertions(+), 10 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3030
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918
Gerrit-PatchSet: 7
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to