Stephen Haberman has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
......................................................................
Patch Set 8:
Okay, I believe this is correct now. CompilerTest all passes. I had not
been handling static fields correctly (or basically at all), which is
likely why typeMarker was broken.
A summary of the change is that, previously, any field with a literal
initializer was set eagerly at top-scope.
However, per the JVM semantics, only static or final fields should be
treated this way.
Non-final/non-static fields with literal initializers should (just like
fields with non-literal initializers) be set with the type's default at
top-scope, and then only later have their initializer assigned in their
class's cstr.
--
To view, visit https://gwt-review.googlesource.com/3030
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918
Gerrit-PatchSet: 8
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman <stephen.haber...@gmail.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Ray Cromwell <cromwell...@google.com>
Gerrit-Reviewer: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Stephen Haberman <stephen.haber...@gmail.com>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
