Goktug Gokdogan has posted comments on this change.
Change subject: Add interfaces for widgets.
......................................................................
Patch Set 6:
(1 comment)
1. It is very important to use consistent naming convention throughout the
SDKs. IsXXX previously used to provide asXXX methods (IsWidget, IsEditor,
IsTreeItem), except 2 cases (IsRenderable, IsCollabsible) which were more
recently added and I think they are both named badly.
2. Looking at the size of this change and thinking of its implications, we
need a very good justification for it. There has been some discussion in
the thread and the reasons for adding these interfaces end up being solely
for testing purposes. More specifically for mocking purposes for specific
style of MVP pattern. I was actually interested in these interfaces for
functional capabilities and we decided to defer that part.
Let's first see a demonstration why mocking options out there
(GWTMockUtilities, gwtmockito, gwt-test-utils, etc...) doesn't fit into our
needs and see if we can fix the problem without this mess. We can use
gathered information from there to document the decision.
....................................................
File user/src/com/google/gwt/dom/client/Style.java
Line 31: public class Style extends JavaScriptObject implements IsStyle {
If you put IsStyle here, no one else can implement this interface - this is
a restriction due to JSOs.
--
To view, visit https://gwt-review.googlesource.com/3231
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd17162d37e367720829bcdaf9a350e446c833b9
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman <stephen.haber...@gmail.com>
Gerrit-Reviewer: Colin Alworth <niloc...@gmail.com>
Gerrit-Reviewer: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Stephen Haberman <stephen.haber...@gmail.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
